Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use harfbuzzjs instead of fontkit #170

Merged
merged 6 commits into from
Apr 15, 2023
Merged

Use harfbuzzjs instead of fontkit #170

merged 6 commits into from
Apr 15, 2023

Conversation

papandreou
Copy link
Collaborator

We use fontkit for getting the codepoints in a font and information about the variation axes. We can use harfbuzzjs for that instead and remove a heavy dependency.

Prerequisite: harfbuzz/harfbuzzjs#77

@papandreou papandreou self-assigned this Apr 8, 2023
@github-actions
Copy link

Pull Request Test Coverage Report for Build 4708973237

  • 22 of 22 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 90.066%
Totals Coverage Status
Change from base Build 4644324050: 0.1%
Covered Lines: 1154
Relevant Lines: 1221
💛 - Coveralls

@papandreou papandreou merged commit 6886a6c into master Apr 15, 2023
@papandreou papandreou deleted the tech/noFontkit branch April 15, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@papandreou papandreou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@papandreou